Hardening/1751 syntax for uri param q and exists #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,27 +30,35 @@ brokerStart CB | |||
| --SHELL-- | |||
There was a problem hiding this comment.
(Discussed at skype) Add some .test to queck attribute existence and not-existence in query operation.
There was a problem hiding this comment.
Functest added in 0b1d496
|
LGTM (passing the ball to @crbrox for final LGTM + merge + delete branch) |
|
LGTM |
crbrox
pushed a commit
that referenced
this pull request
Feb 3, 2016
…uri_param_q_and_exists Hardening/1751 syntax for uri param q and exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed +attr/-attr for attr/!attr in q-string
Added lots of sanity checks for q and q-parts.
Fixes issues #1751 and #1754
Apart from these two issues, q is inspected not to:
These two last checks had to be made before the strtok-loop as strtok doesn't return empty tokens, it just eats them ...