FIX issues related with NGSIv2 refactor (#1720 and #1428) #1727
Conversation
| @@ -49,7 +49,8 @@ std::string parseAttributeValue(ConnectionInfo* ciP, ContextAttribute* caP) | |||
| if (document.HasParseError()) | |||
| { | |||
| alarmMgr.badInput(clientIp, "JSON parse error"); | |||
| oe.fill(SccBadRequest, "Errors found in incoming JSON buffer"); | |||
| oe.reasonPhrase = ERROR_STRING_PARSERROR; | |||
There was a problem hiding this comment.
This could be done with a new fill() method, but not sure if just one case (this one) justifies the creation of the new method...
There was a problem hiding this comment.
Or simply use the old fill() but with this new define:
oe.fill(SccBadRequest, ERROR_STRING_PARSERROR);
Isn't that what you want?
BTW, what about oe.code? Not calling fill, just setting the reasonPhrase might not be enough ...
There was a problem hiding this comment.
Doesn't work that way:
OrionError::OrionError(HttpStatusCode _code, const std::string& _details)
{
code = _code;
reasonPhrase = httpStatusCodeString(code);
details = _details;
}
The reasonPhrase is automatically derived from SccBadRequest (i.e. something like "Bad Request"), but in this case I want to use a different one. And I don't what details be "ERROR_STRING_PARSERROR", but "Errors found in incoming JSON buffer".
There was a problem hiding this comment.
Yeah, I know. We "fixed" the text.
However, you still have no oe.code. You might need one.
To "fix" your problem, we could add a third parameter to the constructor, and default it to NULL:
OrionError::OrionError(HttpStatusCode _code, const std::string& _details, const char* reason = NULL)
{
code = _code;
reasonPhrase = (reason == NULL) httpStatusCodeString(code) : reason;
details = _details;
}
| code = _code; | ||
| reasonPhrase = httpStatusCodeString(code); | ||
| code = SccNone; | ||
| reasonPhrase = _reasonPhrase; | ||
| details = _details; | ||
| } |
There was a problem hiding this comment.
So, you remove the code, setting it no SccNone always?
Not sure this is a good idea ...
There was a problem hiding this comment.
I agree. Probably what is a but idea is a OrionError::OrionError(const std::string _reasonPhrase, const std::string& _details) constructor, without code. I'll have a second pass to OrionError constructors, trying to fix this.
… into bug/prost_verb
Conflicts: src/lib/jsonParseV2/parseSubscription.cpp
|
LGTM |
Fixes:
No CNR entry needed (already covered by the entry about #1259)
@crbrox
@kzangeli