ONANYCHANGE subscriptions #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bscriptions filters)
| @@ -0,0 +1,422 @@ | |||
| # Copyright 2016 Telefonica Investigacion y Desarrollo, S.A.U | |||
There was a problem hiding this comment.
The 4 tests included in this PR are almost identical. Thus, you can review just one and check in the others just the following bits:
- brokerStart line uses -noCache in the proper files
- That condValues is
[]or has been omitted in the proper files.
| * | ||
| * matchExpression | ||
| */ | ||
| static bool matchExpresion(ContextElementResponse* cerP, const std::string& q) |
There was a problem hiding this comment.
matchExpression (one 's' missing)
| @@ -1206,6 +1206,10 @@ static bool addTriggeredSubscriptions_withCache | |||
| aList, | |||
| cSubP->subscriptionId, | |||
| cSubP->tenant); | |||
|
|
|||
| // FIXME P10 #1316: expression needs to be stored in the cache | |||
There was a problem hiding this comment.
P10 ...
Is this something you marked to not forget and then forgot?
Looks important enough to be included in this PR ... ?
There was a problem hiding this comment.
I think it is better to be included in a next PR.
|
LGTM |
kzangeli
pushed a commit
that referenced
this pull request
Jan 18, 2016
…b_in_subs_ngsiv2 ONANYCHANGE subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stated as preparation for expression
qfilter in NGSIv2 subscriptions (thus the name of the branch, referring #1316) but at the end has become an implementation of ONANYCHANGE subscriptions, i.e. #350 (functionality that it is also needed for NGSIv2 subscriptions).(Commit history is a bit weird, maybe due to a not-so-good rebase, but the diff agains develop seems to be ok anyway).