FIX pasrseUrl() function #1653
Merged
FIX pasrseUrl() function #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,8 @@ centos_distro=$(cat /etc/redhat-release 2> /dev/null | awk '{print $3}') | |||
| # Instead the one in previous versions: | |||
| # CentOS release 6.6 (Final) | |||
| # The check in the next line ensure that the distro version is correctly detected in any case. | |||
| if [ $centos_distro == "release" ]; then | |||
| if [ "$centos_distro" = "release" ] | |||
There was a problem hiding this comment.
It seems that == don't work with sh (it works with bash). See http://stackoverflow.com/questions/10849297/compare-a-string-in-unix#comment14133719_10849357.
NTC
|
LGTM (but merge with develop needed) |
…fications Conflicts: CHANGES_NEXT_RELEASE
kzangeli
pushed a commit
that referenced
this pull request
Jan 12, 2016
…lt_port_in_notifications FIX pasrseUrl() function
kzangeli
deleted the
bug/1652_proper_http_default_port_in_notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #1652