Task/part6 attribute value render #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,6 +85,7 @@ typedef struct ContextAttribute | |||
| std::string renderAsJsonObject(ConnectionInfo* ciP, RequestType request, const std::string& indent, bool comma, bool omitValue = false); | |||
| std::string renderAsNameString(ConnectionInfo* ciP, RequestType request, const std::string& indent, bool comma = false); | |||
| std::string toJson(bool isLastElement, bool types, const std::string& renderMode); | |||
| std::string toJsonAsValue(ConnectionInfo* ciP); | |||
There was a problem hiding this comment.
What's the different between toJson() and toJsonAsValue() ?
There was a problem hiding this comment.
Normally ContextAttribute is rendered as
"name": {
"type": "x",
"value": "123",
...
This new method I added for the case "GET /v2/entities/EEE/attr/attrrName/value", where only the value is rendered (and as standalone).
I could have added it to toJson(), with a new parameter, but it would make that method innecessarily complex.
|
LGTM |
fgalan
pushed a commit
that referenced
this pull request
Oct 6, 2015
…_render Task/part6 attribute value render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 6 of #1259 - rendering of attribute value