Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/part3 creation update of attributes #1294

Merged

Conversation

kzangeli
Copy link
Member

Part III of #1259

Practically everything was done during Part I.
Just some error handling was missing (unless I've misunderstood something).

@kzangeli kzangeli added this to the 0.25.0 milestone Sep 25, 2015
# 02. POST /v2/entities, creating E1 with A1
# 03. PUT /v2/entities/E1/attrs/A1 and see it work
# 04. GET /v2/entities/E1/attrs/A1
# 05. PUT /v2/entities/E1/attrs/A1 'old way' - metadatas not inside 'metadata: {}' - see it fail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"old" and "new" may become obsolete when this .test goes outside our memory "remembering scope". Maybe could use a "surname" to help to remember:

"old way" -> "old way" (pre-#1259)
"new way" -> "new way" (post-#1259)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d767fd3 (github-editor - no new functest has been issued ...)

Ken Zangelin added 2 commits September 28, 2015 22:25
More info about 'new way', 'old way'
@fgalan
Copy link
Member

fgalan commented Sep 28, 2015

LGTM

fgalan pushed a commit that referenced this pull request Sep 28, 2015
…_of_attributes

Task/part3 creation update of attributes
@fgalan fgalan merged commit 159c1e2 into feature/1259_new_json_for_v2 Sep 28, 2015
@fgalan fgalan deleted the task/part3_creation_update_of_attributes branch September 28, 2015 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants