logLineMaxSize and logLineMaxSize in the log admin REST API

[fgalan]

In the re-work done in issue #3694 the following parameters were introduced in the CLI:

• -logLineMaxSize
• -logInfoPayloadMaxSize

It could be a good idea to include them in the log admin API, so they can be dyncamically changed, allowing things like this:

PUT /admin/log?infoPayloadMaxSize=10240

GET /admin/log

{
   "level": "INFO"
   "infoPayloadMaxSize": 10240,
   "lineMaxSize": 32768
}

Each setting is associated to a global variable, so connect them with the existing management API shouldn't be difficult.

[Anjali-NEC]

Hi @fgalan Sir,

I would like to work on this issue, Please assign this issue to me. Thank you.

[fgalan]

Assigned. Thank you very much!

[Anjali-NEC]

Hi @fgalan sir,

I have done investigation on this issue. As per my understanding we need to add PUT and GET method for logLineMaxSize and logInfoPayloadMaxSize in log admin API.

To GET logLineMaxSize and logInfoPayloadMaxSize we need to modify serviceRoutinesV2/logLevelTreat.cpp and add "lmLogLinesGet" method for getting logLineMaxSize but I have not found something for PUT method.

Currently I am leaving this issue, and working on another issue.

[Anjali-NEC]

Hi @fgalan Sir,

I am not working on this issue as mention in comment #3707 (comment)

[ArqamFarooqui110719]

Hi @fgalan Sir, I would like to work on this issue, Please assign this issue to me.

I have started the investigation.
Thank you:)

[fgalan]

@ArqamFarooqui110719 you have been assigned

Thanks for your willingness to work on this issue!

[ArqamFarooqui110719]

Hi @fgalan Sir,
As per my investigation, mainly below 2 functions need to be modified for this issue i.e.

changeLogLevel() and getLogLevel()

in src/lib/serviceRoutinesV2/logLevelTreat.cpp file.

I think these function names were given only for the "Log Level" functionality. As now we are modifying the functions and adding new details so these function names should also be change. For e.g.

changeLogDetails() and getLogDetails() respectively.

Please let me know your opinion?

[fgalan]

I'd suggest the following names:

• changeLogConfig()
• getLogConfig()

[ArqamFarooqui110719]

I'd suggest the following names:

• changeLogConfig()
• getLogConfig()

It looks better. Thanks:)

[fgalan]

Fixed by PR #4289