Creates index as per data model #2205
Conversation
|
The usual DM used with STHSink and MongoSink is |
| .append("_id.origin", 1) | ||
| .append("_id.resolution", 1); |
There was a problem hiding this comment.
Why this change in the order of keys instead of keeping the original one? I mean:
| .append("_id.origin", 1) | |
| .append("_id.resolution", 1); | |
| .append("_id.resolution", 1); | |
| .append("_id.origin", 1) |
There was a problem hiding this comment.
Resolved in f7e74e4
| break; | ||
| case DMBYATTRIBUTE: | ||
| keys.append("_id.origin", 1) | ||
| .append("_id.resolution", 1); |
There was a problem hiding this comment.
| .append("_id.resolution", 1); | |
| .append("_id.resolution", 1); |
There was a problem hiding this comment.
Resolved in f7e74e4
| @@ -102,12 +102,26 @@ public void createCollection(String dbName, String collectionName, long dataExpi | |||
| BasicDBObject keys; | |||
| IndexOptions options; | |||
| try { | |||
There was a problem hiding this comment.
From which sink is this createCollection() is being called? MongoSink or STHSink?
There was a problem hiding this comment.
createCollection(String dbName, String collectionName, long dataExpiration) is being called from STHSink
| @@ -162,14 +176,33 @@ public void createCollection(String dbName, String collectionName, long collecti | |||
| } // try catch | |||
There was a problem hiding this comment.
From which sink is this createCollection() is being called? MongoSink or STHSink?
There was a problem hiding this comment.
createCollection(String dbName, String collectionName, long collectionsSize, long maxDocuments, long dataExpiration) is being called from MongoSink
Updated for issue#2204
|
Hi @fgalan , |
| @@ -102,12 +102,26 @@ public void createCollection(String dbName, String collectionName, long dataExpi | |||
| BasicDBObject keys; | |||
There was a problem hiding this comment.
An entry in CHANGES_NEXT_RELEASE file should be included, describing the changes in this PR. Something like this:
[cygnus-common] MongoDB indexes are created depending on DM (#2204)
|
Hi @fgalan, |
|
Documentation about sth indexes: https://github.com/telefonicaid/fiware-sth-comet/blob/master/doc/manuals/db_indexes.md should be updated after this PR changes then depending on the datamodel used. |
This pull request fixes issue #2204