Task/handle textunrestricted attr #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Feb 3, 2022
CHANGES_NEXT_RELEASE
Outdated
| @@ -1,2 +1,3 @@ | |||
| - [cygnus-commons] Check TextUnrestricted type to escape character ' as '' (#2125) | |||
There was a problem hiding this comment.
Maybe something about this should be done in documenation?
Not sure in which .md. Do we have one about NGSIHandler? (in a similar way we have per-sink documents)
fgalan
reviewed
Feb 3, 2022
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_rest_handler.md
Outdated
Show resolved
Hide resolved
fgalan
reviewed
Feb 3, 2022
| @@ -0,0 +1 @@ | |||
| An Attribute value of a TextUnrestricted type from an ContextBroker event is escaped from character ' to '' | |||
There was a problem hiding this comment.
New .md files should be added to mkdoc.yml in the proper place.
There was a problem hiding this comment.
NTC, as the file has been deleted.
Co-authored-by: Fermín Galán Márquez <[email protected]>
fgalan
reviewed
Feb 3, 2022
| @@ -0,0 +1 @@ | |||
| An Attribute value of a TextUnrestricted type from an ContextBroker event is escaped from character ' to '' | |||
There was a problem hiding this comment.
Suggested change
| An Attribute value of a TextUnrestricted type from an ContextBroker event is escaped from character ' to '' | |
| Cygnus escapes from `'` to `''` in attributes of type `TextUnrestricted` with the aim of avoiding injection attacks. | |
| Note that other attributes (i.e. with type different to `TextUnrestricted` don't need such escaping as single quote (`'`) is a [forbidden character in Context Broker](https://fiware-orion.readthedocs.io/en/master/user/forbidden_characters/index.html) so that value will never arrives to Cygnus in notifications. |
To align the text with the one used in the other .md file.
fgalan
reviewed
Feb 3, 2022
fgalan
reviewed
Feb 3, 2022
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_rest_handler.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
This was referenced Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2125
This fix applies to all sinks, all modes (row and column) but only for attr types which are TextUnrestricted