Fix/prepared statement #1960
Merged
Fix/prepared statement #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Oct 15, 2020
| @@ -581,12 +581,21 @@ public void upsertTransaction (LinkedHashMap<String, ArrayList<JsonElement>> agg | |||
| String insertQuery = SQLQueryUtils.sqlInsertQuery(aggregation, | |||
There was a problem hiding this comment.
CNR entry (with reference to issue number, if we have some) should be included.
fgalan
reviewed
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes PreparedStatement behaviour.
Before this PR the final statement was builded with native sql driver methods, but it's failing when inserting some SQL objects. The ones identified are Timestamp with TZ and functions.(An issue was created to take a deeper look at this miss behaviour #1959)
With this PR the SQL query is builded as a plain String (as it does usually on the insert query).