Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/add config option persist errors #1930

Merged
merged 11 commits into from
Sep 15, 2020
Merged

Task/add config option persist errors #1930

merged 11 commits into from
Sep 15, 2020

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Sep 15, 2020 •
edited
Loading

@AlvaroVega AlvaroVega requested a review from IvanHdzC September 15, 2020 12:34
fgalan
fgalan reviewed Sep 15, 2020
View reviewed changes
CHANGES_NEXT_RELEASE
@@ -1,2 +1,3 @@
[cygnus-common][SQLBackendImpl] Add configuration option to persist errors in SQL sinks (#1928)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the existing functionality for PG?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make it optional by config

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. NTC

fgalan
fgalan reviewed Sep 15, 2020
View reviewed changes
cygnus-ngsi/conf/agent_ngsi.conf.template
@@ -197,7 +197,8 @@ cygnus-ngsi.sinks.postgresql-sink.type = com.telefonica.iot.cygnus.sinks.NGSIPos
#cygnus-ngsi.sinks.postgresql-sink.batch_timeout = 30
# number of retries upon persistence error
#cygnus-ngsi.sinks.postgresql-sink.batch_ttl = 10

# true if errors are persisted for this sink, false otherwise
#cygnus-ngsi.sinks.postgresql-sink.persist_errors = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are per-sink docu tables with the allowed parameters. Maybe persiste_errors should be added to all them.

fgalan
fgalan approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IvanHdzC
IvanHdzC approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@IvanHdzC IvanHdzC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanHdzC IvanHdzC merged commit 7cd18f7 into master Sep 15, 2020
@IvanHdzC IvanHdzC deleted the task/add_config_option_persist_errors branch September 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanHdzC IvanHdzC IvanHdzC approved these changes

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @fgalan @IvanHdzC