Fix/attribute metadata #1923
Merged
Fix/attribute metadata #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR reopens #1919 so no CNR update is needed |
fgalan
reviewed
Sep 4, 2020
| @@ -108,7 +108,8 @@ public void aggregate(NGSIEvent event) { | |||
| String attrType = contextAttribute.getType(); | |||
| JsonElement attrValue = contextAttribute.getValue(); | |||
| String attrMetadata = contextAttribute.getContextMetadata(); | |||
| JsonArray jsonAttrMetadata = new Gson().fromJson(attrMetadata, JsonArray.class); | |||
| JsonParser jsonParser = new JsonParser(); | |||
| JsonArray jsonAttrMetadata = (JsonArray) jsonParser.parse(attrMetadata); | |||
There was a problem hiding this comment.
Maybe some test should be added covering the failing case (now solved by the PR)?
There was a problem hiding this comment.
previous PR #1919 were modifying existing tests about this feature
There was a problem hiding this comment.
So I understand new tests are not needed.
In that case, NTC.
AlvaroVega
reviewed
Sep 4, 2020
| @@ -92,7 +96,8 @@ public void aggregate(NGSIEvent event) { | |||
| aggregation.get(NGSIConstants.ATTR_NAME).add(new JsonPrimitive(attrName)); | |||
| aggregation.get(NGSIConstants.ATTR_TYPE).add(new JsonPrimitive(attrType)); | |||
| aggregation.get(NGSIConstants.ATTR_VALUE).add(attrValue); | |||
| aggregation.get(NGSIConstants.ATTR_MD).add(new JsonPrimitive(attrMetadata)); | |||
| aggregation.get(NGSIConstants.ATTR_MD).add(jsonAttrMetadata); | |||
| //aggregation.get(NGSIConstants.ATTR_MD).add(new JsonPrimitive(attrMetadata)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the mentioned exception on. #1902.
On the entity that failed when persisting on the comment, this would be the persistance json.
Persisting data at NGSICKANSink (orgName=dipbad, pkgName=dipbad_envairqualityrespira, resName=bada1_respira, data={"recvTime":"2020-09-04T07:05:54.756Z","fiwareServicePath":"/envAirQualityRESPIRA","entityId":"bada1","entityType":"RESPIRA","TimeInstant":"2020-07-01T20:32:06.000Z","TimeInstant_md":[{"name":"dateCreated","type":"DateTime","value":"2020-01-10T10:08:33.000Z"},{"name":"dateModified","type":"DateTime","value":"2020-07-08T10:55:38.000Z"}],"airQualityIndex":31,"airQualityIndex_md":[{"name":"dateCreated","type":"DateTime","value":"2020-01-10T10:08:33.000Z"},{"name":"dateModified","type":"DateTime","value":"2020-07-08T10:55:38.000Z"}]})