Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of makes implicit variables #23

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

martin-g
Copy link
Contributor

See https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

This makes is easier for the user to overwrite the compiler, e.g. to use Clang, and the compiler and linker flags.
Without such improvement I needed to use sed to add LDFLAGS support for the Bioconda build - bioconda/bioconda-recipes#47230

Also added a new Github Actions workflow that shows usage of make and demoes overwriting of the implicit variables.

@telatin
Copy link
Owner

telatin commented Apr 15, 2024

Thanks a million! Will look into it ASAP

Copy link
Owner

@telatin telatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job @martin-g

@telatin telatin merged commit 68dfbdf into telatin:main Apr 16, 2024
4 checks passed
@martin-g martin-g deleted the better-makefile branch April 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants