Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable insiders documentation features #65

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Nov 25, 2024

Proposed changes

Enable insiders documentation features

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner November 25, 2024 17:37
@nfelt14 nfelt14 enabled auto-merge (squash) November 25, 2024 17:39
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (0399f83) to head (e9629bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   90.70%   90.59%   -0.12%     
==========================================
  Files          28       28              
  Lines        1797     1797              
  Branches      274      274              
==========================================
- Hits         1630     1628       -2     
- Misses        104      106       +2     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Nov 29, 2024

@v12ganesh please review this.

v12ganesh
v12ganesh previously approved these changes Nov 29, 2024
@nfelt14 nfelt14 force-pushed the nfelt14/enable-insiders-documentation-features branch from 7502cba to 7ca3a1b Compare December 3, 2024 15:58
Copy link

github-actions bot commented Dec 3, 2024

Breaking API Changes

src/tm_data_types/files_and_formats/waveform_file.py:0: <module>:
Public object was removed

Link to workflow run

Copy link

github-actions bot commented Dec 3, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

Copy link

github-actions bot commented Dec 3, 2024

Test Results (windows)

path passed subtotal
tests\test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

Copy link

github-actions bot commented Dec 3, 2024

Test Results (macos)

path passed subtotal
tests/test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

@nfelt14 nfelt14 requested review from v12ganesh and a team and removed request for qthompso December 3, 2024 17:15
@nfelt14
Copy link
Collaborator Author

nfelt14 commented Dec 3, 2024

@v12ganesh, please re-review this, I had to push some updates to get builds to pass.

@nfelt14 nfelt14 requested a review from amccann-Tek December 3, 2024 21:32
@nfelt14 nfelt14 merged commit d60bb3e into main Dec 4, 2024
65 checks passed
@nfelt14 nfelt14 deleted the nfelt14/enable-insiders-documentation-features branch December 4, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants