-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable insiders documentation features #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt14
temporarily deployed
to
package-build
November 25, 2024 17:37 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 90.70% 90.59% -0.12%
==========================================
Files 28 28
Lines 1797 1797
Branches 274 274
==========================================
- Hits 1630 1628 -2
- Misses 104 106 +2
Partials 63 63 ☔ View full report in Codecov by Sentry. |
nfelt14
requested review from
v12ganesh,
qthompso,
ArunKumarTek,
pradhanfortive and
tekperson
November 26, 2024 06:51
@v12ganesh please review this. |
v12ganesh
previously approved these changes
Nov 29, 2024
Also add missing docstrings and enable linting checks for docstrings.
nfelt14
force-pushed
the
nfelt14/enable-insiders-documentation-features
branch
from
December 3, 2024 15:58
7502cba
to
7ca3a1b
Compare
Breaking API Changes
|
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
nfelt14
requested review from
v12ganesh and
a team
and removed request for
qthompso
December 3, 2024 17:15
@v12ganesh, please re-review this, I had to push some updates to get builds to pass. |
v12ganesh
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enable insiders documentation features
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>