Add Support for fetching forwarded logs from third party API #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
kind/feature
khrm
commented
Aug 7, 2024
tekton-robot
removed
the
needs-rebase
tekton-robot
added
needs-rebase
|
The following is the coverage report on the affected files.
|
khrm
force-pushed
the
f/forwarder
branch
2 times, most recently
from
3902d6f to
31cc999
Compare
|
/test pull-tekton-results-integration-tests |
2 similar comments
|
/test pull-tekton-results-integration-tests |
|
/test pull-tekton-results-integration-tests |
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-results-integration-tests |
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-results-integration-tests |
|
The following is the coverage report on the affected files.
|
|
/assign anithapriyanatarajan |
khrm
force-pushed
the
f/forwarder
branch
2 times, most recently
from
47df5b8 to
5fecf2a
Compare
|
The following is the coverage report on the affected files.
|
khrm
force-pushed
the
f/forwarder
branch
2 times, most recently
from
f95a28d to
5205601
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-results-unit-tests |
|
|
|
REST API endpoints are also working fine: |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
avinal
approved these changes
Sep 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avinal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@khrm I have no other comments and I'm ready to lgtm this change. You mentioned above you are going to add another update based on Avinal's comment. Once you are ready, I'll lgtm. Otherwise it'll be removed on update or merge automatically before. |
This enables the support for fetching logs from Third Party API. This pr enables the support for Lokistack logs which are forwarded using vector, fluentbit or fluentd. Other stack like ELK, splunk, etc can be added later on.
|
/retest |
|
@enarha I have updated with that change. |
|
/lgtm |
|
The following is the coverage report on the affected files.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the support for fetching logs from Third Party API. This pr enables the support for Lokistack
logs which are forwarded using vector, fluentbit or fluentd.
Other stack like ELK, splunk, etc can be added later on.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes