Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owner references check optional in watcher #672

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add owner references check optional in watcher #672

merged 1 commit into from
Nov 28, 2023

Conversation

sayan-biswas
Copy link
Contributor

As per discussion in #648

Changes

This PR makes the owner reference check in watcher optional.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

"check_owner" command line flag allows the Owner References check to be optional while deleting resources.

@sayan-biswas sayan-biswas added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2023
@sayan-biswas sayan-biswas self-assigned this Nov 22, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4

@sayan-biswas
Copy link
Contributor Author

/test pull-tekton-results-build-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4

enarha
enarha reviewed Nov 22, 2023
View reviewed changes
cmd/watcher/main.go Show resolved Hide resolved
docs/watcher/README.md Outdated Show resolved Hide resolved
@sayan-biswas
Add owner references check optional in watcher
83e1477 
This feature makes the owner reference check in watcher optional.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4

@Roming22 Roming22 mentioned this pull request Nov 27, 2023
Closed
Roming22
Roming22 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

@Roming22: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enarha
Copy link
Contributor

enarha commented Nov 27, 2023

/approve
/lgtm on behalf of @Roming22

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@avinal
Copy link
Member

avinal commented Nov 28, 2023 •
edited
Loading

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, enarha, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avinal
Copy link
Member

avinal commented Nov 28, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@tekton-robot tekton-robot merged commit 097030b into tektoncd:main Nov 28, 2023
6 checks passed
@ramessesii2 ramessesii2 mentioned this pull request Nov 30, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarha enarha enarha left review comments

@Roming22 Roming22 Roming22 approved these changes

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

Assignees

@sayan-biswas sayan-biswas

@avinal avinal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayan-biswas @tekton-robot @enarha @avinal @Roming22