-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use enviornment variables for watcher cli args #662
Conversation
Using enviornment variable substitution for default cli args allows for modification of values via strategic merge patches instead of JSON6902. This reduces complexity of patches, allows for easier namespace overrides as well as a cleaner overlay
Hi @drGrove. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
- -api_addr | ||
- $(TEKTON_RESULTS_API_SERVICE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be cleaner?
- -api_addr | |
- $(TEKTON_RESULTS_API_SERVICE) | |
- -api_addr=$(TEKTON_RESULTS_API_SERVICE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way seems fine.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other config flags available for the watcher. So a long term solution would be to implement the knative configMap loader. Which will also reduce the complexity of patching.
But I guess this okay for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avinal, james-callahan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/kind misc |
Using enviornment variable substitution for default cli args allows for modification of values via strategic merge patches instead of JSON6902. This reduces complexity of patches, allows for easier namespace overrides as well as a cleaner overlay
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes