Replace the interface{} type with the shorter any #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
sayan-biswas
approved these changes
Oct 10, 2023
tekton-robot
added
the
approved
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
avinal
requested changes
Oct 17, 2023
enarha
force-pushed
the
replace-empty-interface-any
branch
from
9afbfb7
to
d63fdee
Compare
tekton-robot
added
size/M
|
@avinal good point. I updated the PR to exclude the .pb.go files as well (in addition to vendor/). |
Go 1.18 includes the predeclared identifier "any", which is a shorter
alias of "interface{}". The following command was used to replace each
instance of "interface{}" with "any" in the codebase excluding the
vendor directory and auto generated protobuf files (.pb.go).
`gofmt -r 'interface{} -> any' -w .`
enarha
force-pushed
the
replace-empty-interface-any
branch
from
d63fdee
to
9d244ae
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avinal, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.18 includes the pre-declared identifier "any", which is a shorter alias of "interface{}". The following command was used to replace each instance of "interface{}" with "any" in the codebase excluding the vendor directory and auto generated protobuf files (.pb.go).
gofmt -r 'interface{} -> any' -w ./kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep