Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfreeze the Pipelines version to latest in e2e tests. #613

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Unfreeze the Pipelines version to latest in e2e tests. #613

merged 1 commit into from
Dec 1, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 21, 2023 •
edited
Loading

Change v0.47.2 to the latest version of pipelines
Fixes #612

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@khrm
Unfreeze the Pipelines version to latest in e2e tests.
da4d054 
Change v0.47.2 to latest version of pipelines
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 21, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2023
@khrm khrm added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 21, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note-none Denotes a PR that doesnt merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 21, 2023
khrm
khrm commented Sep 21, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 21, 2023
@khrm
Copy link
Contributor Author

khrm commented Sep 21, 2023

Latest isn't giving us latest, that's why this failed.

@khrm
Copy link
Contributor Author

khrm commented Sep 21, 2023

Issue here for latest not giving latest: tektoncd/pipeline#7122

@khrm
Copy link
Contributor Author

khrm commented Sep 21, 2023

/retest

@khrm
Copy link
Contributor Author

khrm commented Sep 25, 2023

/test pull-tekton-results-integration-tests

@ramessesii2
Copy link
Member

/approve
/lgtm

@tekton-robot
Copy link

@ramessesii2: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm khrm mentioned this pull request Oct 31, 2023
Closed
8 tasks
@enarha
Copy link
Contributor

enarha commented Oct 31, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@khrm
Copy link
Contributor Author

khrm commented Nov 30, 2023

@sayan-biswas @avinal Let's merge this. It has been opened since a long time and not much change to review.

@sayan-biswas
Copy link
Contributor

/lgtm

@avinal
Copy link
Member

avinal commented Dec 1, 2023

/lgtm

@avinal
Copy link
Member

avinal commented Dec 1, 2023

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, ramessesii2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@tekton-robot tekton-robot merged commit 3350fff into main Dec 1, 2023
4 checks passed
@khrm khrm deleted the khrm-patch-1 branch April 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramessesii2 ramessesii2 ramessesii2 approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@enarha enarha Awaiting requested review from enarha

Assignees

@sayan-biswas sayan-biswas

@enarha enarha

@avinal avinal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unfreeze the Pipelines version to latest in e2e tests.
6 participants
@khrm @ramessesii2 @tekton-robot @enarha @sayan-biswas @avinal