Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tkn-results to use latest version of results #550

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

avinal
Copy link
Member

@avinal avinal commented Aug 4, 2023

Changes

  • go1.17 support has already ended, bump tkn-results to 1.19
  • replace deprecated methods
  • bump results version in tkn-results

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

- tkn-results bumped to use v0.7.0 of results
- tkn-results Go version bumped to go1.19

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2023
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2023
@tekton-robot
Copy link

Hi @avinal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avinal
Copy link
Member Author

avinal commented Aug 4, 2023

I have a feeling that it would be better to break it into two commits or even two PRs. Please let me know.

@adambkaplan
Copy link
Contributor

@avinal two commits makes the most sense:

  • First commit - update to go 1.19, run go mod tidy && go mod vendor
  • Second commit - refactors related to code updates.

@adambkaplan
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2023
@avinal avinal force-pushed the avinal/bump-and-move branch from c44b052 to 44f6f80 Compare August 4, 2023 14:37
@avinal
Copy link
Member Author

avinal commented Aug 4, 2023

I did not run go mod vendor for tkn-results. It is currently not in the main tree and many dependencies will be duplicated. Filed #551 for moving in tree.

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to merge older prs of cli.

@avinal
Copy link
Member Author

avinal commented Aug 4, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 4, 2023
@avinal avinal force-pushed the avinal/bump-and-move branch from 44f6f80 to a13c254 Compare August 4, 2023 14:51
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@khrm khrm added this to the v0.8.0 milestone Aug 24, 2023
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avinal needs a small rebase

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@avinal
Copy link
Member Author

avinal commented Aug 31, 2023

Hey Vincent, we are holding this PR until other CLI prs are merged. I will rebase as soon they are meregd.

- go 1.17 is already EOL, upgrade to go1.19

Signed-off-by: Avinal Kumar <[email protected]>
@avinal avinal force-pushed the avinal/bump-and-move branch from a13c254 to d1256ee Compare September 4, 2023 09:34
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2023
@avinal
Copy link
Member Author

avinal commented Sep 4, 2023

I have tested the bump with the latest changes in tkn-results, everything is working as expected. PTAL

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@tekton-robot tekton-robot merged commit 3d9801d into tektoncd:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants