-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tkn-results to use latest version of results #550
Conversation
Hi @avinal. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I have a feeling that it would be better to break it into two commits or even two PRs. Please let me know. |
@avinal two commits makes the most sense:
|
/ok-to-test |
c44b052
to
44f6f80
Compare
I did not run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to merge older prs of cli.
/kind misc |
44f6f80
to
a13c254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avinal needs a small rebase
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey Vincent, we are holding this PR until other CLI prs are merged. I will rebase as soon they are meregd. |
- go 1.17 is already EOL, upgrade to go1.19 Signed-off-by: Avinal Kumar <[email protected]>
Signed-off-by: Avinal Kumar <[email protected]>
a13c254
to
d1256ee
Compare
I have tested the bump with the latest changes in tkn-results, everything is working as expected. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes