Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLS hostname override #536

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

sayan-biswas
Copy link
Contributor

@sayan-biswas sayan-biswas commented Jul 20, 2023

Changes

Removes the TLS hostname override option and disables TLS verification for the internal gRPC client used for proxying incoming request to gRPC server.

Fixes #521

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

ACTION REQUIRED: Config option, TLS_HOSTNAME_OVERRIDE is removed as the internal gRPC proxy client doesn't need to reverify the TLS.

@sayan-biswas sayan-biswas added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2023
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 20, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
@sayan-biswas sayan-biswas requested a review from enarha July 25, 2023 08:42
Removes the TLS hostname override option and disables TLS verification for the internal gRPC client used for proxying incoming request to gRPC server.
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@adambkaplan
Copy link
Contributor

This should have an ACTION REQUIRED prefix on the release note. This introduces a "breaking" change by removing a deployment configuration option.

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2023
@sayan-biswas
Copy link
Contributor Author

This should have an ACTION REQUIRED prefix on the release note. This introduces a "breaking" change by removing a deployment configuration option.

Updated release note.

@enarha
Copy link
Contributor

enarha commented Aug 16, 2023

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@tekton-robot tekton-robot merged commit 3643dcc into tektoncd:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liveness and Readiness probes fail with recommended certificate setup
5 participants