Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Release Cheatsheet for Results #441

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add Release Cheatsheet for Results #441

merged 1 commit into from
Sep 15, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Apr 26, 2023 •
edited
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 26, 2023
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 26, 2023
khrm
khrm commented Apr 26, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 26, 2023
@khrm
Copy link
Contributor Author

khrm commented Apr 27, 2023

@enarha

avinal
avinal previously requested changes Apr 27, 2023
View reviewed changes
@khrm
Copy link
Contributor Author

khrm commented Apr 27, 2023

Fixes #388

@khrm khrm force-pushed the relcheatsheet branch from 22bbc9a to 51a77cb Compare May 25, 2023 11:39
enarha
enarha reviewed Jun 26, 2023
View reviewed changes
tekton/release-cheatsheet.md
from the release branch. Refer to previous releases to confirm the expected format.
1. Un-check the "This is a pre-release" checkbox since you're making a legit for-reals release!

1. Publish the GitHub release once all notes are correct and in order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing a step to make the release "the default release". It's just another checkbox to fill.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to add this for a minor release.

Copy link
Contributor Author

@khrm khrm Aug 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phrased it below:

Mark the release as "the default release" if it's not a patch release or the patch release of the latest release.

@enarha
Copy link
Contributor

enarha commented Jun 26, 2023

Generally the documentation is good. Following it, I was able to do the v0.7.0 release. There was an issue with storing the release.yaml and version folders in the correct paths, so I had to fix those manually. I'll look into this later to determine if it's something we need to fix in the script or in the documentation.

@khrm khrm force-pushed the relcheatsheet branch 6 times, most recently from d313f50 to 74d8756 Compare August 21, 2023 13:33
@khrm khrm force-pushed the relcheatsheet branch 5 times, most recently from 7282215 to 5cd0d89 Compare September 4, 2023 13:12
@khrm
Copy link
Contributor Author

khrm commented Sep 6, 2023

Does this release cheatsheet work fine? @enarha

@enarha
Copy link
Contributor

enarha commented Sep 6, 2023 •
edited
Loading

The Cheatsheet is good and we can merge that PR. There is an issue which is a bug in some of the release scripts used. I've created #595 to handle it.
[EDIT] I see I also mentioned that after the previous release, but unfortunately I did not follow up with a fix. Now that we have the issue, I hope it brings more attention to it.

@enarha
Copy link
Contributor

enarha commented Sep 6, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@khrm
Copy link
Contributor Author

khrm commented Sep 15, 2023

@avinal Let's approve this. It might fix the go coverage test that's failing if this gets merged.

@avinal
Copy link
Member

avinal commented Sep 15, 2023

Yeah last release was successful, for now its good. We can iterate on this.

/approve
/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@khrm khrm dismissed avinal’s stale review September 15, 2023 14:02

Addressed the review.

@khrm khrm merged commit 9565619 into tektoncd:main Sep 15, 2023
@khrm khrm deleted the relcheatsheet branch September 15, 2023 14:02
@avinal avinal mentioned this pull request Sep 18, 2023
Closed
@avinal avinal linked an issue Sep 18, 2023 that may be closed by this pull request
Document release process #388
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@enarha enarha enarha left review comments

@avinal avinal avinal left review comments

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@enarha enarha

@avinal avinal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document release process
5 participants
@khrm @enarha @avinal @tekton-robot @afrittoli