Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install: add option for localhost DNS name #326

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Install: add option for localhost DNS name #326

merged 1 commit into from
Jun 20, 2023

Conversation

adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Jan 19, 2023 •
edited
Loading

Update the install script to use localhost as an optional DNS alternative in the generated certificate. This can facilitate developer testing.

NONE

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 19, 2023
@alan-ghelardi
Copy link
Contributor

Is it worth documenting this option in the docs/development.md file?

@adambkaplan
Copy link
Contributor Author

Updated the doc of the e2e install script. Once #319 merges, I think we can update the debugging doc to use curl instead of the gRPC client. And if we fix up tkn-results, we can advocate that as the right way to go.

@alan-ghelardi
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2023
khrm
khrm reviewed Jan 24, 2023
View reviewed changes
test/e2e/01-install.sh Outdated
@@ -66,7 +73,7 @@ set -e
kubectl create secret tls -n tekton-pipelines tekton-results-tls --cert="${SSL_CERT_PATH}/tekton-results-cert.pem" --key="${SSL_CERT_PATH}/tekton-results-key.pem" || true

echo "Installing Tekton Results..."
kubectl kustomize "${ROOT}/test/e2e/kustomize" | ko apply -f -
kubectl kustomize "${ROOT}/test/e2e/kustomize" | ko apply --sbom=none -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we disable sbom?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local testing, SBOM isn't useful. SBOM generation adds extra time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this is also for e2e testing. At times I have tested with quay.io as my image repo, and pushing the SBOM does not always succeed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a known issue but it should be fixed in the latest version: ko-build/ko#532. I haven't tried it recently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have to try and reproduce the issue. Sounds like an issue with quay.io.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like quay.io doesn't like spdx+json media types in some circumstances. Commented in ko-build/ko#660 (comment) - it looks like ko has support for text/spdx+json on the long term roadmap?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm can we resolve this thread?

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023
@avinal
Copy link
Member

avinal commented Mar 2, 2023

@adambkaplan Please rebase.

@adambkaplan
Install: add option for localhost DNS name
bd90155 
- Update the install script to use localhost as an optional DNS
  alternative in the generated certificate. This can facilitate
  developer testing.
- Documented options for the install script in the e2e README.
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesnt merit a release note. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 20, 2023
@adambkaplan
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 20, 2023
@adambkaplan adambkaplan added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 20, 2023
avinal
avinal approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alan-ghelardi, avinal, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alan-ghelardi,sayan-biswas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@tekton-robot tekton-robot merged commit 9affa7f into tektoncd:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@enarha enarha enarha left review comments

@sayan-biswas sayan-biswas sayan-biswas approved these changes

@avinal avinal avinal approved these changes

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@sayan-biswas sayan-biswas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adambkaplan @alan-ghelardi @avinal @tekton-robot @sayan-biswas @khrm @enarha