Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the support for reading Results and Records across multiple collections #249

Conversation

alan-ghelardi
Copy link
Contributor

What

This pull request resolves #248, which
provides a more detailed explanation about the rationale. Essentially, these
changes allow users to list results across parents and list records across
results without a prior knowledge of the parent name.

@tekton-robot
Copy link

Hi @alan-ghelardi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2022
@dibyom
Copy link
Member

dibyom commented Oct 7, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2022
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to use - to mean "all namespaces" for the parent, then we need to modify the RBAC auth check [1]. - is not a valid namespace, and the best case is that subject access review will fail with an invalid namespace. Worst case - it always succeeds, which would be a security vulnerability.

Ideally we would have an e2e test covering this. I feel that is too much to ask for in this PR.

[1] https://github.com/tektoncd/results/blob/main/pkg/api/server/v1alpha2/auth/rbac.go#L85-L94

@alan-ghelardi alan-ghelardi force-pushed the enhance-support-for-reading-resources-across-multiple-collections branch from ebc79ff to 2c2e0ac Compare October 9, 2022 15:27
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@tekton-robot tekton-robot merged commit 42b0180 into tektoncd:main Oct 10, 2022
@alan-ghelardi
Copy link
Contributor Author

@adambkaplan thank you for accepting the pull request. I started writing an E2E test case for that scenario, but I stumbled upon the mtls. I'm working on that and I send a new pull request once it's done.

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature
We need this label for release as discussed in the last WG call.

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow listing results and records without a prior knowledge of the parent name
6 participants