-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the support for reading Results and Records across multiple collections #249
Enhance the support for reading Results and Records across multiple collections #249
Conversation
Hi @alan-ghelardi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to use -
to mean "all namespaces" for the parent, then we need to modify the RBAC auth check [1]. -
is not a valid namespace, and the best case is that subject access review will fail with an invalid namespace. Worst case - it always succeeds, which would be a security vulnerability.
Ideally we would have an e2e test covering this. I feel that is too much to ask for in this PR.
[1] https://github.com/tektoncd/results/blob/main/pkg/api/server/v1alpha2/auth/rbac.go#L85-L94
ebc79ff
to
2c2e0ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adambkaplan thank you for accepting the pull request. I started writing an E2E test case for that scenario, but I stumbled upon the mtls. I'm working on that and I send a new pull request once it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
We need this label for release as discussed in the last WG call.
What
This pull request resolves #248, which
provides a more detailed explanation about the rationale. Essentially, these
changes allow users to list results across parents and list records across
results without a prior knowledge of the parent name.