-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable high availability through Knative leader election support #242
Enable high availability through Knative leader election support #242
Conversation
Hi @alan-ghelardi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// Lister is a generic signature of Lister.List functions, by allowing us to | ||
// support various listers in the NewLeaderAwareFuncs function below. | ||
type Lister[O metav1.Object] func(labels.Selector) ([]O, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
We need this label for release as discussed in the last WG call.
What
config-leader-election ConfigMap allows users to tweak the leader election
mechanism. The other two ones make Results more homogeneous with Tekton
Pipeline project.
Why
This pull request resolves #241, which
contains more details on why this feature is relevant. Essentially, it allows
users to tweak the Watcher controller to deal with higher loads more easily.
Additional information
I tested those changes in a local Kind cluster and they're working as
expected. When the standard leader election mode is enabled, one replica
reconciles PipelineRuns and TaskRuns while the other one does nothing. When the
statefulset mode is enabled with three replicas for instance, all instances
reconcile different keys simultaneously.