Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ko version in ko-gcloud to v0.5.1 from v0.5.0 #427

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Bump ko version in ko-gcloud to v0.5.1 from v0.5.0 #427

merged 1 commit into from
Jul 6, 2020

Conversation

a-roberts
Copy link
Member

@a-roberts a-roberts commented Jun 16, 2020

Changes

Fixes #426 - hopefully. Todo build ourselves and prove it fixes this, and check the upgrade is safe for everything else in Tekton.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot requested review from abayer and kimsterv June 16, 2020 18:38
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2020
@tekton-robot
Copy link
Contributor

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Contributor

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@a-roberts
Copy link
Member Author

a-roberts commented Jun 16, 2020

Let's see if this works

/kind/bug
(it didn't, boo)

(gonna treat it as a bug because 0.5.0 has an issue whereby the files it produces, we think, have the wrong permissions)

@ghost
Copy link

ghost commented Jun 16, 2020

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2020
@ghost
Copy link

ghost commented Jun 16, 2020

Digging back through some slightly older issues I spy #370 which hasn't closed out yet and a thread on ko that I think suggests this is fixed in 0.5.1? ko-build/ko#164

I'm not sure if there's a way to test this short of merging it and seeing what fails. WDYT @afrittoli ?

@vdemeester
Copy link
Member

Also, https://github.com/google/ko/releases shows that 0.5.0 and 0.5.1 are targeting the same commit 😅

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@tekton-robot tekton-robot merged commit 9ce7e60 into tektoncd:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we bump the ko image to be 0.5.1 from 0.5.0?
3 participants