-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ko version in ko-gcloud to v0.5.1 from v0.5.0 #427
Conversation
This PR cannot be merged: expecting exactly one kind/ label Available
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
Let's see if this works /kind/bug (gonna treat it as a bug because 0.5.0 has an issue whereby the files it produces, we think, have the wrong permissions) |
/kind bug |
Digging back through some slightly older issues I spy #370 which hasn't closed out yet and a thread on ko that I think suggests this is fixed in 0.5.1? ko-build/ko#164 I'm not sure if there's a way to test this short of merging it and seeing what fails. WDYT @afrittoli ? |
Also, https://github.com/google/ko/releases shows that 0.5.0 and 0.5.1 are targeting the same commit 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #426 - hopefully. Todo build ourselves and prove it fixes this, and check the upgrade is safe for everything else in Tekton.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.