Change ko:gcloud-latest image to ko-gcloud:latest #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the "gcloud-latest" tag breaks the default image pull policy, we should use the "latest" tag instead.
tekton-robot
added
the
size/XS
ghost
approved these changes
May 5, 2020
tekton-robot
added
the
approved
afrittoli
added a commit
to afrittoli/pipeline
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
ghost
approved these changes
May 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
|
/lgtm |
|
/lgtm |
afrittoli
added a commit
to afrittoli/tektoncd-dashboard
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
1 task
afrittoli
added a commit
to afrittoli/triggers
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
1 task
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
tekton-robot
pushed a commit
to tektoncd/dashboard
that referenced
this pull request
May 5, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
eddycharly
pushed a commit
to eddycharly/dashboard
that referenced
this pull request
May 6, 2020
Use ko-cloud:latest instead of ko:gcloud-latest Reference: tektoncd/plumbing#370 Depends on tektoncd/plumbing#375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Using the "gcloud-latest" tag breaks the default image pull policy,
we should use the "latest" tag instead.
Work towards #370
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.