Turn on PRCommenter on completion of PR builds #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
added
the
kind/feature
|
/assign @afrittoli @dibyom |
tekton-robot
added
the
size/M
Closes tektoncd#483 I could have added a new `TriggerTemplate`, but it made more sense to just turn the existing `tekton-ci-github-check-end` into a `PipelineRun`. I did have to add a couple new parameters - the bare repo name (since I wrote up the PR commenter to have the org as a global configuration), and a boolean for pass/fail. It may make sense to tweak the PR commenter to handle `org/repo` instead of just `repo`, and `"success"` or `"failure"` instead of `true` or `false`, but I thought I'd wait to see what people think. =) Signed-off-by: Andrew Bayer <[email protected]>
abayer
force-pushed
the
start-using-pr-commenter
branch
from
5840e44 to
cb196bc
Compare
|
This looks good to me! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
abayer
added a commit
to abayer/plumbing
that referenced
this pull request
Sep 30, 2022
Specifically reverting tektoncd#1220 and tektoncd#1225 Something's wrong with how this is actually working in practice - I'm not seeing the `PipelineRun` get created, so I'm _guessing_ something's awry in the eventlistener. But I don't know enough to figure out what's wrong. So let's revert this for the moment. Signed-off-by: Andrew Bayer <[email protected]>
2 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Sep 30, 2022
Specifically reverting #1220 and #1225 Something's wrong with how this is actually working in practice - I'm not seeing the `PipelineRun` get created, so I'm _guessing_ something's awry in the eventlistener. But I don't know enough to figure out what's wrong. So let's revert this for the moment. Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #483
I could have added a new
TriggerTemplate, but it made more sense to just turn the existingtekton-ci-github-check-endinto aPipelineRun.I did have to add a couple new parameters - the bare repo name (since I wrote up the PR commenter to have the org as a global configuration), and a boolean for pass/fail. It may make sense to tweak the PR commenter to handle
org/repoinstead of justrepo, and"success"or"failure"instead oftrueorfalse, but I thought I'd wait to see what people think. =)/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.