Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Artifact type to a pointer #8226

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Aug 28, 2024

Prior to this, the Artifacts in TaskRunStatusFields was not set to a pointer of the underlying struct. As a result, it was incompatible with tkn. Here we fix that issue by updating it to a pointer.

Fixes #8225

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix Artifact type to a pointer.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Aug 28, 2024
@chitrangpatel
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 28, 2024
@chitrangpatel
Copy link
Contributor Author

/cherry-pick release-v0.62.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-v0.62.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Prior to this, the Artifacts in TaskRunStatusFields was not set to
a pointer of the underlying struct. As a result, it was incompatible
with `tkn`. Here we fix that issue by updating it to a `pointer`.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/artifact_types.go 95.5% 95.7% 0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 97.3% 0.0

@chitrangpatel
Copy link
Contributor Author

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@tekton-robot tekton-robot merged commit c910594 into tektoncd:main Aug 30, 2024
13 of 14 checks passed
@tekton-robot
Copy link
Collaborator

@chitrangpatel: #8226 failed to apply on top of branch "release-v0.62.x":

Applying: Fix Artifact type to a pointer
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1/openapi_generated.go
M	pkg/apis/pipeline/v1/swagger.json
M	pkg/apis/pipeline/v1/taskrun_types.go
M	pkg/apis/pipeline/v1/zz_generated.deepcopy.go
M	pkg/pod/status.go
M	pkg/pod/status_test.go
M	pkg/reconciler/pipelinerun/resources/apply_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/pipelinerun/resources/apply_test.go
Auto-merging pkg/pod/status_test.go
CONFLICT (content): Merge conflict in pkg/pod/status_test.go
Auto-merging pkg/pod/status.go
Auto-merging pkg/apis/pipeline/v1/zz_generated.deepcopy.go
Auto-merging pkg/apis/pipeline/v1/taskrun_types.go
Auto-merging pkg/apis/pipeline/v1/swagger.json
Auto-merging pkg/apis/pipeline/v1/openapi_generated.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Artifact type to a pointer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

Did it manually here : #8228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tkn not working with old pipeline release
4 participants