Switch the image from docker.io to gcr mirror #8146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XXL
|
/kind misc |
tekton-robot
added
the
kind/misc
wlynch
reviewed
Jul 22, 2024
test/taskrun_test.go
Outdated
| @@ -208,7 +208,7 @@ spec: | |||
| if d := cmp.Diff(taskrun.Status.Steps, expectedStepState, ignoreTerminatedFields, ignoreStepFields); d != "" { | |||
| t.Fatalf("-got, +want: %v", d) | |||
| } | |||
| // Note(chmouel): Sometime we have docker-pullable:// or docker.io/library as prefix, so let only compare the suffix | |||
Docker hub reduced its rate limit to a 100 container pulls per hour. This is very small and making our tests flaky. As a stop gap, we think that changing to `mirror.gcr.io` will get us past the rate limit since the image will be pushed from the artifact registry cache instead of docker hub.
chitrangpatel
force-pushed
the
switch-to-artifact-registry-images
branch
from
5a031ac to
824a41a
Compare
pritidesai
reviewed
Jul 23, 2024
|
/approve @chitrangpatel are we ready to merge now or waiting for an additional setting around |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@pritidesai I think we can start with this. Adding the imagePullPolicy is a bit more involved and will probably come in a follow-up PR. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker hub reduced its rate limit to a 100 container pulls per hour. This is very small and making our tests flaky. As a stop gap, we think that changing to
mirror.gcr.iowill get us past the rate limit since the image will be pushed from the artifact registry cache instead of docker hub.Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes