-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.56.x] Cleanup resolved object before validating through dry-run #8064
[release-v0.56.x] Cleanup resolved object before validating through dry-run #8064
Conversation
This ensure that we are not going to fail during validation with dry-run. An example of such a failure would be the following scenario. - A task in a namespace has `ownerReferences` with `blockOwnerDeletion: true` - A user uses the `cluster` resolver to fetch that task - That user doesn't have a lot of rights in that namespace (only listing Tasks for example). /kind bug Signed-off-by: Vincent Demeester <[email protected]> (cherry picked from commit d3b18ea) (cherry picked from commit a89b964)
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
2 similar comments
/retest |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Cherry picked fro #8051
This ensure that we are not going to fail during validation with
dry-run. An example of such a failure would be the following scenario.
ownerReferences
withblockOwnerDeletion: true
cluster
resolver to fetch that tasklisting Tasks for example).
/kind bug
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes