-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e2e-test script for per-feature flag test #7657
Conversation
b44d53b
to
baf6c15
Compare
baf6c15
to
9424689
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
cc @tektoncd/core-maintainers can I get a lgtm for this given the coming release cutoff? |
There is one test file right now - https://github.com/tektoncd/pipeline/blob/main/test/per_feature_flags_test.go with this flag, I am assuming we are enabling it with this PR. /lgtm |
Yes, thanks @pritidesai , this shall work with the plumbing setup . Will keep an eye on the prow results. |
Changes
This commit updates the e2e test script for per feature flag test.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes