Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e-test script for per-feature flag test #7657

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Feb 12, 2024

Changes

This commit updates the e2e test script for per feature flag test.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 12, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2024
@JeromeJu JeromeJu added this to the Pipelines v0.57 milestone Feb 12, 2024
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2024
@JeromeJu JeromeJu changed the title Add prow env for pre feature flag test Add prow env for per-feature flag test Feb 13, 2024
@JeromeJu JeromeJu changed the title Add prow env for per-feature flag test Update e2e-test script for per-feature flag test Feb 13, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@JeromeJu
Copy link
Member Author

/retest

@JeromeJu
Copy link
Member Author

cc @tektoncd/core-maintainers can I get a lgtm for this given the coming release cutoff?

@pritidesai
Copy link
Member

There is one test file right now - https://github.com/tektoncd/pipeline/blob/main/test/per_feature_flags_test.go with this flag, I am assuming we are enabling it with this PR.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@JeromeJu
Copy link
Member Author

There is one test file right now - https://github.com/tektoncd/pipeline/blob/main/test/per_feature_flags_test.go with this flag, I am assuming we are enabling it with this PR.

/lgtm

Yes, thanks @pritidesai , this shall work with the plumbing setup . Will keep an eye on the prow results.

@tekton-robot tekton-robot merged commit 123f4a2 into tektoncd:main Feb 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants