-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0144] Add feature flag and doc placeholder #7279
[TEP-0144] Add feature flag and doc placeholder #7279
Conversation
Skipping CI for Draft Pull Request. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm
13d2685
to
e4b43a9
Compare
Part of [tektoncd#7270][tektoncd#7270]. In [TEP-0144][tep-0144] we proposed a new `enum` field to support built-in param input validation. This commit adds the feature flag `enable-param-enum` and documentation placeholder for the feature. /kind feature [tektoncd#7270]: tektoncd#7270 [tep-0144]: https://github.com/tektoncd/community/blob/main/teps/0144-param-enum.md
e4b43a9
to
b9df1f6
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Hi @pritidesai @tektoncd/core-maintainers . I saw your comment here around getting reviews from >1 organizations: #7260 (comment) I totally agree with the point, especially for PR involves major changes/concepts (like introducing a new CRD); and I believe we follow the rule strictly in TEP proposals. Going forward, I was wondering for smaller implementation PRs like this, do you feel comfortable if reviews are from the same organization to favour productivity, if they have good domain knowledge? |
@QuanZhang-William I also had the same thoughts, raised it for discussion at the governance/community meeting today and opened tektoncd/community#1097 for discussion and to clarify the policy, you're welcome to also chime in there |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you for breaking down this work @QuanZhang-William 🙏🏾 /lgtm adding this note as suggested in tektoncd/community#1097 (comment): sought more input here and on slack but haven't received any yet, this is a small and specific change that was discussed in a TEP plus it can be easily changed if needed (alpha) |
Changes
Part of #7270. In TEP-0144 we proposed a new
enum
field to support built-in param input validation.This commit adds the feature flag
enable-param-enum
and documentation placeholder for the feature./kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes