Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0145] Add CEL evaluation #7255

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[TEP-0145] Add CEL evaluation #7255

merged 1 commit into from
Oct 26, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Oct 21, 2023 •
edited
Loading

Changes

4th PR of TEP-0145 tracked by #7244.

This commit adds CEL evaluation. Users are able to use CEL in WhenExpression if the feature flag enable-cel-in-whenexpression is enabled.If the evluation is false, the PipelineTask will be skipped.

/kind feature

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Support CEL expression in WhenExpression to guard the execution of Tasks

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.0% -2.1

@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.0% -2.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.0% -2.1

@Yongxuanzhang Yongxuanzhang mentioned this pull request Oct 23, 2023
Closed
5 tasks
@Yongxuanzhang
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.0% -2.1

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Oct 23, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review October 23, 2023 18:59
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.8% -1.2

@Yongxuanzhang Yongxuanzhang force-pushed the cel-tep-145-3 branch 2 times, most recently from cfbc2db to 4b7e408 Compare October 23, 2023 19:32
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.8% -1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.8% -1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.0% -0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 95.8% -1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.5% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 96.7% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.5% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 96.7% -0.4

jerop
jerop reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an example 🙏🏾

you can update this example: https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/pipelinerun-with-when-expressions.yaml

@Yongxuanzhang
Copy link
Member Author

Yongxuanzhang commented Oct 24, 2023 •
edited
Loading

please add an example 🙏🏾

you can update this example: https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/pipelinerun-with-when-expressions.yaml

I do have an example added: examples/v1/pipelineruns/alpha/pipelinerun-with-cel-when-expressions.yaml
That's one reason I didn't add e2e test since the example is running as part of the e2e test. I'm working on adding an e2e test now if the example isn't enough

@jerop
Copy link
Member

jerop commented Oct 24, 2023

ah it's all good then, thanks!

jerop
jerop approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Yongxuanzhang 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@jerop
Copy link
Member

jerop commented Oct 25, 2023

@tektoncd/core-maintainers requesting reviews on this PR 🙏🏾

This is the last PR implementing CEL in When Expressions -- #7244

chitrangpatel
chitrangpatel reviewed Oct 25, 2023
View reviewed changes
test/e2e-tests.sh Outdated Show resolved Hide resolved
@JeromeJu
Copy link
Member

/assign

@JeromeJu JeromeJu mentioned this pull request Oct 25, 2023
Merged
7 tasks
@Yongxuanzhang
[TEP-0145] Add CEL evaluation
edb003e 
This commit adds CEL evaluation. Users are able to use CEL in
WhenExpression if the feature flag enable-cel-in-whenexpression is
enabled.If the evluation is false, the PipelineTask will be skipped.

Signed-off-by: Yongxuan Zhang [email protected]
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.5% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 96.7% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.5% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 96.7% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 92.4% 92.5% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 97.1% 96.7% -0.4

@Yongxuanzhang
Copy link
Member Author

/retest
error resolving image references: GET https://distroless.dev/v2/: unexpected status code 503 Service Unavailable
https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7255/pull-tekton-pipeline-alpha-integration-tests/1717273228327522304

vdemeester
vdemeester approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit faf6044 into tektoncd:main Oct 26, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

@chitrangpatel chitrangpatel

@jerop jerop

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.53 LTS
Development

Successfully merging this pull request may close these issues.
7 participants
@Yongxuanzhang @tekton-robot @jerop @JeromeJu @vdemeester @chitrangpatel @afrittoli