[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

Yongxuanzhang · 2023-10-19T19:18:57Z

Changes

This commit is the 2nd PR of TEP-0145 tracking issue is #7244.

This commit adds CEL field to the WhenExpression, a feature flag enable-cel-in-whenexpression to guard the new api field.

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-10-19T19:19:00Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Yongxuanzhang · 2023-10-19T19:19:10Z

/kind feature

tekton-robot · 2023-10-19T19:28:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	93.0%	-0.9
pkg/apis/pipeline/v1/when_validation.go	100.0%	62.5%	-37.5
pkg/apis/pipeline/v1beta1/when_validation.go	100.0%	62.5%	-37.5

Yongxuanzhang · 2023-10-19T19:47:46Z

/test pull-tekton-pipeline-unit-tests

pkg/apis/pipeline/v1/when_types.go

tekton-robot · 2023-10-19T20:31:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

tekton-robot · 2023-10-19T20:38:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

pkg/apis/config/feature_flags.go

tekton-robot · 2023-10-19T20:42:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1/when_validation.go	100.0%	96.0%	-4.0

tekton-robot · 2023-10-19T20:58:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

tekton-robot · 2023-10-19T20:59:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

tekton-robot · 2023-10-19T21:00:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

jerop

@Yongxuanzhang thanks for breaking down the implementation

Can we please add incremental docs as well, so in this PR we can include docs for the API and feature flag -- and add a note that this is work in progress 🙏🏾

pkg/apis/pipeline/v1/when_types.go

pkg/apis/pipeline/v1/when_validation_test.go

… the field add cel to the WhenExpression, a feature flag enable-cel-in-whenexpression to guard thie new api field. Signed-off-by: Yongxuan Zhang [email protected]

tekton-robot · 2023-10-20T17:21:17Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

tekton-robot · 2023-10-20T17:22:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/pipeline_conversion.go	95.3%	95.4%	0.0

tekton-robot · 2023-10-20T17:22:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

docs/pipeline-api.md

chitrangpatel · 2023-10-20T18:33:08Z

/lgtm

Yongxuanzhang · 2023-10-20T19:58:21Z

/retest

Yongxuanzhang · 2023-10-20T20:04:01Z

The failing test: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7247/pull-tekton-pipeline-alpha-integration-tests/1715445654538424320
was introduced in #7100, may be a new flaky test

chitrangpatel · 2023-10-20T20:17:57Z

The failing test: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7247/pull-tekton-pipeline-alpha-integration-tests/1715445654538424320
was introduced in #7100, may be a new flaky test

Yes, I think the content is there, just the ordering is different. This will be very flaky.

Fixing now. cc @chengjoey

Yongxuanzhang · 2023-10-20T20:40:23Z

/retest

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 19, 2023

tekton-robot requested review from afrittoli and vdemeester October 19, 2023 19:19

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 19, 2023

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2023

Yongxuanzhang mentioned this pull request Oct 19, 2023

[TEP-0145] CEL in WhenExpression #7244

Closed

5 tasks

Yongxuanzhang force-pushed the cel-tep-145-1 branch from 83e5b6c to d48d115 Compare October 19, 2023 19:47

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023

Yongxuanzhang force-pushed the cel-tep-145-1 branch from d48d115 to c98847b Compare October 19, 2023 20:06

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023

Yongxuanzhang force-pushed the cel-tep-145-1 branch from c98847b to 0322e41 Compare October 19, 2023 20:13

Yongxuanzhang marked this pull request as ready for review October 19, 2023 20:15

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023

tekton-robot requested review from bobcatfish and pritidesai October 19, 2023 20:15

Yongxuanzhang commented Oct 19, 2023

View reviewed changes

pkg/apis/pipeline/v1/when_types.go Show resolved Hide resolved

Yongxuanzhang force-pushed the cel-tep-145-1 branch from 0322e41 to 4999539 Compare October 19, 2023 20:25

tektoncd deleted a comment from tekton-robot Oct 19, 2023

jerop reviewed Oct 19, 2023

View reviewed changes

pkg/apis/config/feature_flags.go Outdated Show resolved Hide resolved

Yongxuanzhang force-pushed the cel-tep-145-1 branch 2 times, most recently from 00f70fb to 145ba47 Compare October 19, 2023 20:51

Yongxuanzhang requested a review from jerop October 20, 2023 16:36

jerop reviewed Oct 20, 2023

View reviewed changes

pkg/apis/pipeline/v1/when_types.go Show resolved Hide resolved

pkg/apis/pipeline/v1/when_validation_test.go Outdated Show resolved Hide resolved

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard…

e487bfb

… the field add cel to the WhenExpression, a feature flag enable-cel-in-whenexpression to guard thie new api field. Signed-off-by: Yongxuan Zhang [email protected]

Yongxuanzhang force-pushed the cel-tep-145-1 branch from 145ba47 to e487bfb Compare October 20, 2023 17:13

Yongxuanzhang requested a review from jerop October 20, 2023 17:15

jerop approved these changes Oct 20, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023

chitrangpatel reviewed Oct 20, 2023

View reviewed changes

docs/pipeline-api.md Show resolved Hide resolved

tekton-robot assigned chitrangpatel Oct 20, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023

tekton-robot merged commit 4026876 into tektoncd:main Oct 20, 2023
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

Yongxuanzhang commented Oct 19, 2023 •

edited

Loading

tekton-robot commented Oct 19, 2023

Yongxuanzhang commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

Yongxuanzhang commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

jerop left a comment

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

chitrangpatel commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

chitrangpatel commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

[TEP-0145] Add CEL field to WhenExpression, and feature flag to guard the field #7247

Conversation

Yongxuanzhang commented Oct 19, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Oct 19, 2023

Yongxuanzhang commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

Yongxuanzhang commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

tekton-robot commented Oct 19, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

chitrangpatel commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

chitrangpatel commented Oct 20, 2023

Yongxuanzhang commented Oct 20, 2023

Yongxuanzhang commented Oct 19, 2023 •

edited

Loading