Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up getting substitution expressions #7121

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jerop
Copy link
Member

@jerop jerop commented Sep 15, 2023

Changes

Prior to this change, the functions for fetching substitution expressions were inconsistent in the codebase.

This change updates the functions for fetching substitition expressions from Parameters and Pipeline Results such that they are member functions, in line with related functions.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps

  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Prior to this change, the functions for fetching substitution
expressions were inconsistent in the codebase.

This change updates the functions for fetching substitition
expressions from Parameters and Pipeline Results such that
they are member functions, in line with related functions.

/kind cleanup
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@jerop
Copy link
Member Author

jerop commented Sep 15, 2023

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.4% -0.4
pkg/apis/pipeline/v1/pipeline_types.go 84.8% 87.2% 2.3
pkg/apis/pipeline/v1/resultref.go 98.2% 100.0% 1.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.4% -0.4
pkg/apis/pipeline/v1/pipeline_types.go 84.8% 87.2% 2.3
pkg/apis/pipeline/v1/resultref.go 98.2% 100.0% 1.8

@jerop
Copy link
Member Author

jerop commented Sep 18, 2023

/retest

@chitrangpatel
Copy link
Contributor

/assign

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@jerop jerop added this to the Pipelines v0.52 milestone Sep 19, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@tekton-robot tekton-robot merged commit 4446f4e into tektoncd:main Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants