-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up getting substitution expressions #7121
Clean up getting substitution expressions #7121
Conversation
Prior to this change, the functions for fetching substitution expressions were inconsistent in the codebase. This change updates the functions for fetching substitition expressions from Parameters and Pipeline Results such that they are member functions, in line with related functions. /kind cleanup
/test check-pr-has-kind-label |
@jerop: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
/assign |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Prior to this change, the functions for fetching substitution expressions were inconsistent in the codebase.
This change updates the functions for fetching substitition expressions from Parameters and Pipeline Results such that they are member functions, in line with related functions.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new releaseRelease Notes