Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove results annotations filtering #7108

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Remove results annotations filtering #7108

merged 1 commit into from
Sep 20, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 13, 2023 •
edited
Loading

We require some of the results annotations at creation time.
Fixes #6857

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind bug

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2023
@khrm
Copy link
Contributor Author

khrm commented Sep 13, 2023

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor Author

khrm commented Sep 13, 2023

This was created based on discussion at #6858

@khrm khrm mentioned this pull request Sep 13, 2023
Closed
7 tasks
@khrm
Copy link
Contributor Author

khrm commented Sep 13, 2023

/cherry-pick release-v0.50.x

@tekton-robot
Copy link
Collaborator

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.50.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

khrm
khrm commented Sep 13, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor Author

khrm commented Sep 13, 2023

/assign @pritidesai @lbernick @vdemeester @afrittoli

@khrm
Copy link
Contributor Author

khrm commented Sep 13, 2023

Can someone put this in the v0.52 milestone? The previous pr ##6858 one was in the milestone.

@pritidesai pritidesai added this to the Pipelines v0.52 milestone Sep 13, 2023
@khrm
Remove results annotations filtering
bb47601 
We require some of results annotations at creation time.
Fixes tektoncd#6857
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2023
@wlynch
Copy link
Member

wlynch commented Sep 15, 2023

/lgtm

(I'd run this by another results maintainer just in case)

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@ramessesii2 ramessesii2 mentioned this pull request Sep 17, 2023
Merged
5 tasks
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramessesii2, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
khrm
khrm commented Sep 20, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-pipeline-alpha-integration-tests

khrm
khrm commented Sep 20, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit d783556 into tektoncd:main Sep 20, 2023
2 checks passed
@tekton-robot
Copy link
Collaborator

@khrm: new pull request created: #7131

In response to this:

/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Sep 20, 2023
Merged
@khrm khrm deleted the removeResultReserveAnn branch September 20, 2023 11:25
@khrm khrm mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramessesii2 ramessesii2 ramessesii2 approved these changes

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@wlynch wlynch

@afrittoli afrittoli

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.52
Development

Successfully merging this pull request may close these issues.

Results Summary Annotation is being filtered
8 participants
@khrm @tekton-robot @wlynch @vdemeester @ramessesii2 @pritidesai @afrittoli @lbernick