Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate beta features for inline pipelines and tasks #7079

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

lbernick
Copy link
Member

Prior to this commit, validation of beta features was performed for v1 referenced Tasks and Pipelines (both local and remote), but not v1 inline Tasks and Pipelines.

This commit ensures that beta feature validation is the same for both inline and referenced Tasks and Pipelines.

/kind bug

Closes #7077

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bug fix: validate beta features in inline tasks/pipelines in the same way as referenced tasks/pipelines

Prior to this commit, validation of beta features was performed for v1 referenced
Tasks and Pipelines (both local and remote), but not v1 inline Tasks and Pipelines.

This commit ensures that beta feature validation is the same for both inline and referenced
Tasks and Pipelines.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 30, 2023
@lbernick lbernick requested a review from JeromeJu August 30, 2023 13:46
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.0% 94.0% 0.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 97.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.0% 94.0% 0.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 97.8% 0.0

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@tekton-robot tekton-robot merged commit 8c6bd54 into tektoncd:main Aug 30, 2023
2 checks passed
@JeromeJu
Copy link
Member

Redirecting the discussion at #7077 (comment) on whether we would want to backport this:
I think we might need to decide whether to backport this or not? From my understanding, it is good practice to backport while the reason for not backporting this one specifically is that the changes could be breaking users who choose to use enable-api-fields=stable and are using beta features in the past, which is similar to the decouple api and feature versioning change.

@lbernick
Copy link
Member Author

I'd be in favor of backporting, since this is a bug fix that restores behavior prior to 0.49.
/cherry-pick release-v0.50.x

@tekton-robot
Copy link
Collaborator

@lbernick: new pull request created: #7080

In response to this:

I'd be in favor of backporting, since this is a bug fix that restores behavior prior to 0.49.
/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta features for inline Task and Pipeline not validated
4 participants