-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate beta features for inline pipelines and tasks #7079
Conversation
Prior to this commit, validation of beta features was performed for v1 referenced Tasks and Pipelines (both local and remote), but not v1 inline Tasks and Pipelines. This commit ensures that beta feature validation is the same for both inline and referenced Tasks and Pipelines.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Redirecting the discussion at #7077 (comment) on whether we would want to backport this: |
I'd be in favor of backporting, since this is a bug fix that restores behavior prior to 0.49. |
@lbernick: new pull request created: #7080 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Prior to this commit, validation of beta features was performed for v1 referenced Tasks and Pipelines (both local and remote), but not v1 inline Tasks and Pipelines.
This commit ensures that beta feature validation is the same for both inline and referenced Tasks and Pipelines.
/kind bug
Closes #7077
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes