Bump knative/pkg to 1.11 #6975

vdemeester · 2023-07-26T12:24:25Z

Changes

Bump knative/pkg to the latest, 1.11

This also updates the min kubernetes version to 1.25.

/kind misc

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bump knative.dev/pkg to 1.11 so the Kubernetes min version is now 1.25

tekton-robot · 2023-07-26T12:56:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-26T12:58:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

vdemeester · 2023-07-26T13:16:18Z

Ah this needs a change in plumbing..

vdemeester · 2023-07-26T13:29:54Z

This will need tektoncd/plumbing#1520
cc @afrittoli @tektoncd/plumbing-maintainers

vdemeester · 2023-07-26T13:33:12Z

… And AddEventHandler interface changed in client-go.. yay 🙃

vdemeester · 2023-07-28T08:42:28Z

/retest

tekton-robot · 2023-07-28T10:00:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-28T10:04:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-28T10:37:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-28T10:41:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-28T14:18:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-28T14:19:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-07-31T08:14:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-08-01T13:23:17Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-08-01T13:25:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

pkg/reconciler/events/cloudevent/cloudeventclient.go

tekton-robot · 2023-08-03T13:54:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2023-08-04T07:59:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-08-04T08:03:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

vdemeester · 2023-08-04T08:44:51Z

/retest

afrittoli

Thank you @vdemeester !
/lgtm

vdemeester · 2023-08-08T09:59:50Z

arg.. needs a rebase 😅

This does the following: - Update the dependency of knative/pkg to 1.11 - Update k8s reference to 1.25 as it's now the k8s min version supported - Remove "use" of injection.Dynamic (not really used) See knative/pkg#2739. It doesn't seem it was used anywhere anyway. - Handle AddEventHandler error. The `AddEventHandler` interface has changed and now returns an error (and a registration object that we do not need to use for now). This handles the error if any arise and also makes the linter happy :). Signed-off-by: Vincent Demeester <[email protected]>

afrittoli · 2023-08-08T12:36:01Z

/lgtm

tekton-robot · 2023-08-08T12:42:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot · 2023-08-08T12:43:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	18.2%	11.1%	-7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go	31.8%	28.6%	-3.2
pkg/reconciler/notifications/customrun/controller.go	100.0%	90.9%	-9.1
pkg/reconciler/pipelinerun/controller.go	100.0%	82.6%	-17.4
pkg/reconciler/resolutionrequest/controller.go	100.0%	85.7%	-14.3
pkg/reconciler/taskrun/controller.go	95.2%	87.0%	-8.3
pkg/resolution/resolver/framework/controller.go	55.4%	55.2%	-0.2
pkg/taskrunmetrics/injection.go	18.2%	11.1%	-7.1

tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 26, 2023

tekton-robot requested review from dibyom and imjasonh July 26, 2023 12:24

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2023

This was referenced Jul 26, 2023

Injection client uses knative type that has been deleted #6848

Closed

go.mod: bump versions #6824

Closed

vdemeester force-pushed the bump-knative-1.11 branch from b82d52a to dc06b4f Compare July 28, 2023 09:54

vdemeester force-pushed the bump-knative-1.11 branch from dc06b4f to 1b096a0 Compare July 28, 2023 10:31

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2023

vdemeester force-pushed the bump-knative-1.11 branch 2 times, most recently from 9f056cd to fc2dbe0 Compare July 28, 2023 14:13

vdemeester force-pushed the bump-knative-1.11 branch from fc2dbe0 to c9a16e8 Compare July 31, 2023 08:08

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2023

vdemeester closed this Aug 1, 2023

vdemeester reopened this Aug 1, 2023

afrittoli reviewed Aug 1, 2023

View reviewed changes

pkg/reconciler/events/cloudevent/cloudeventclient.go Show resolved Hide resolved

lbernick approved these changes Aug 3, 2023

View reviewed changes

pkg/reconciler/events/cloudevent/cloudeventclient.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023

vdemeester force-pushed the bump-knative-1.11 branch from c9a16e8 to e108830 Compare August 4, 2023 07:53

afrittoli reviewed Aug 8, 2023

View reviewed changes

tekton-robot assigned afrittoli Aug 8, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2023

vdemeester force-pushed the bump-knative-1.11 branch from e108830 to 1b5f226 Compare August 8, 2023 12:34

tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023

tekton-robot merged commit 31c9a8c into tektoncd:main Aug 8, 2023

vdemeester deleted the bump-knative-1.11 branch August 8, 2023 14:35

savitaashture mentioned this pull request Aug 17, 2023

Bump knative/pkg to 1.11 tektoncd/triggers#1630

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump knative/pkg to 1.11 #6975

Bump knative/pkg to 1.11 #6975

vdemeester commented Jul 26, 2023

tekton-robot commented Jul 26, 2023

tekton-robot commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 31, 2023

tekton-robot commented Aug 1, 2023

tekton-robot commented Aug 1, 2023

tekton-robot commented Aug 3, 2023

tekton-robot commented Aug 4, 2023

tekton-robot commented Aug 4, 2023

vdemeester commented Aug 4, 2023

afrittoli left a comment

vdemeester commented Aug 8, 2023

afrittoli commented Aug 8, 2023

tekton-robot commented Aug 8, 2023

tekton-robot commented Aug 8, 2023

Bump knative/pkg to 1.11 #6975

Bump knative/pkg to 1.11 #6975

Conversation

vdemeester commented Jul 26, 2023

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jul 26, 2023

tekton-robot commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 26, 2023

vdemeester commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 28, 2023

tekton-robot commented Jul 31, 2023

tekton-robot commented Aug 1, 2023

tekton-robot commented Aug 1, 2023

tekton-robot commented Aug 3, 2023

tekton-robot commented Aug 4, 2023

tekton-robot commented Aug 4, 2023

vdemeester commented Aug 4, 2023

afrittoli left a comment

Choose a reason for hiding this comment

vdemeester commented Aug 8, 2023

afrittoli commented Aug 8, 2023

tekton-robot commented Aug 8, 2023

tekton-robot commented Aug 8, 2023