Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stability Level for CSI and Projected Volume Workspaces #6954

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Update Stability Level for CSI and Projected Volume Workspaces #6954

merged 1 commit into from
Jul 21, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jul 20, 2023 •
edited
Loading

Changes

This commit updates the stability level for csi and projected volume workspaces, which have both been documented as they have became stable according to TEP096.
Prior to this change, they would still require beta enable-api-fields to be enabled given that the documentations in TEP096 shows they are stable..

/kind feature
related: #6948

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

csi and projected volume workspaces are stable.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 20, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
@JeromeJu JeromeJu changed the title Update Stability Level for CSI and Projected Workspaces Update Stability Level for CSI and Projected Volume Workspaces Jul 20, 2023
@JeromeJu JeromeJu force-pushed the update-stability-level branch from 1693d09 to 829a9f2 Compare July 20, 2023 18:57
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/workspace_validation.go 97.6% 100.0% 2.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/workspace_validation.go 97.6% 100.0% 2.4

@JeromeJu JeromeJu mentioned this pull request Jul 20, 2023
Closed
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/workspace_validation.go 97.6% 100.0% 2.4

vdemeester
vdemeester reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2023
@JeromeJu
Update Stability Level for CSI and Projected Volume Workspaces
1502452 
This commit updates the stability level for csi and projected
volume workspaces, which have both been documented as they have
became stable according to TEP096.
@JeromeJu JeromeJu force-pushed the update-stability-level branch from 829a9f2 to 1502452 Compare July 21, 2023 14:59
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/workspace_validation.go 97.6% 100.0% 2.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/workspace_validation.go 97.6% 100.0% 2.4

jerop
jerop approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 443e380 into tektoncd:main Jul 21, 2023
@JeromeJu JeromeJu mentioned this pull request Jul 24, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@jerop jerop jerop approved these changes

@lbernick lbernick lbernick approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeromeJu @tekton-robot @vdemeester @jerop @lbernick