Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger Fatalf message #6946

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix logger Fatalf message #6946

merged 1 commit into from
Jul 21, 2023

Conversation

bhujangr
Copy link
Contributor

@bhujangr bhujangr commented Jul 20, 2023 •
edited by pritidesai
Loading

This commit fixes the typos in the package termination_test where the fix is transforming Errot to Error

/kind cleanup

Sidenote: Working with @pritidesai at IBM, towards contributing to TektonCD Pipeline and as part of this am using this trivial cosmetic change PR to iron out issues pertinent to opensource contribution

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@bhujangr
Fix logger Fatalf message
36994b3 
This commit fixes the typos in the package termination_test where
the fix is transforming Errot to Error
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 20, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bhujangr / name: Bhujang Rajendran (36994b3)

@tekton-robot
Copy link
Collaborator

Hi @bhujangr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2023
@pritidesai
Copy link
Member

thank you @bhujangr 👍

Welcome to the Tekton community, looking forward to many more contributions!

/ok-to-test
/kind misc

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/misc Categorizes issue or PR as a miscellaneuous one. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2023
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
vdemeester
vdemeester approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pritidesai,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pritidesai
Copy link
Member

/retest

@pritidesai
Copy link
Member

/test pull-tekton-pipeline-go-coverage

1 similar comment
@jerop
Copy link
Member

jerop commented Jul 21, 2023

/test pull-tekton-pipeline-go-coverage

@tekton-robot tekton-robot merged commit d0baae2 into tektoncd:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhujangr @tekton-robot @pritidesai @jerop @vdemeester