Cleanup: Remove "substituted context" task validation #6671
Conversation
Prior to this commit, when a sentinel value was injected into the context, TaskSpec.Validate skipped most validation. However, there are no places in the codebase, other than tests, where this sentinel value was used. This commit removes this logic. No functional changes.
tekton-robot
added
kind/cleanup
tekton-robot
added
the
size/L
tekton-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
It looks like all these test failures are actually flakes-- all are related to git clone failures that I think are transient and definitely aren't related to this PR. The alpha integration tests failed due to #6626. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, JeromeJu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
|
/retest everything seems to be failures fetching/cloning git 🤔 |
|
/retest I think things are working again based on the prow dashboard |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
Prior to this commit, when a sentinel value was injected into the context, TaskSpec.Validate skipped most validation. This logic was introduced in #4835. However, there are no longer places in the codebase, other than tests, where this sentinel value was used. This commit removes this logic. No functional changes.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes