-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enable-api-fields validation for array index replacements #6646
Conversation
Prior to this commit, the PipelineRun and TaskRun reconcilers checked whether "enable-api-fields" was set to "alpha" or "beta" before performing array param index replacement.. There were several problems with this logic: - Beta CRDs don't require "enable-api-fields" to be "beta" to use beta features. - This validation depends on the API version of the CRD that was created, so it belongs in the admission webhook rather than the reconciler. - If "enable-api-fields" was set to "stable", param replacement was skipped. This means a user could create a valid array indexing expression in a beta CRD, and the reconciler would not correctly replace this param with its value.
The following is the coverage report on the affected files.
|
3e531fe
to
6203c3c
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prior to this commit, the PipelineRun and TaskRun reconcilers checked whether "enable-api-fields" was set to "alpha" or "beta" before performing array param index replacement..
There were several problems with this logic:
This commit removes this logic.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes