Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development guide on creating new CRDs #6566

Merged
merged 1 commit into from
Apr 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,10 @@ If you need to add a new CRD type, you will need to add:
- [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml)
1. Add go structs for the types in
[pkg/apis/pipeline/v1alpha1](./pkg/apis/pipeline/v1alpha1) e.g
[condition_types.go](./pkg/apis/pipeline/v1alpha1/condition_types.go) This
[verificationpolicy_types.go](./pkg/apis/pipeline/v1alpha1/verificationpolicy_types.go) This
should implement the
[Defaultable](./pkg/apis/pipeline/v1alpha1/condition_defaults.go) and
[Validatable](./pkg/apis/pipeline/v1alpha1/condition_validation.go)
[Defaultable](./pkg/apis/pipeline/v1alpha1/verificationpolicy_defaults.go) and
[Validatable](./pkg/apis/pipeline/v1alpha1/verificationpolicy_validation.go)
interfaces as they are needed for the webhook in the next step.
1. Register it with the [webhook](./cmd/webhook/main.go)
1. Add the new type to the
Expand Down