Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the system-installed version of golangci-lint. #6560

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Use the system-installed version of golangci-lint. #6560

merged 1 commit into from
Apr 19, 2023

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Apr 19, 2023 •
edited
Loading

Changes

See this thread: https://tektoncd.slack.com/archives/CJ4ERJWAU/p1681920119203019

Context: #5899

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

/kind misc
/assign vdemeester

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Apr 19, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2023
vdemeester
vdemeester requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So… doing that would break the Makefile though 😅
I would rather update the version here or adapt the presubmit.sh file ? (or remove the GOLANGCILINT variable from the Makefile.

cc @afrittoli @abayer

Basically, we need to decide what is the source of truth for the CI. As of today, it's the one in the Makefile, so doing make golangci-lint gives you the guarantee you will have the same version as you do on the CI (no matter what the container image or the system has installed) — and I do like that to be honest 😝

@bendory
Copy link
Contributor Author

bendory commented Apr 19, 2023

So… doing that would break the Makefile though 😅 I would rather update the version here or adapt the presubmit.sh file ? (or remove the GOLANGCILINT variable from the Makefile.

Yeah, you're right. 😢

Can we go forward with this to unblock me while you sort out the larger issue?

@bendory
Upgraded golangci-lint to version 1.52.2.
bff5843 
See this thread: https://tektoncd.slack.com/archives/CJ4ERJWAU/p1681920119203019

Context: #5899

Disabled `revive` linter; upgrade results in a high number of new unused
variables not previously identified in the previous version.
vdemeester
vdemeester approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as is (with updating the GOLANGCI_VERSION in the Makefile), let's go
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@tekton-robot tekton-robot merged commit 7fa5620 into tektoncd:main Apr 19, 2023
@bendory bendory deleted the lintversion branch April 19, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendory @tekton-robot @vdemeester