Run events controller as separate binary #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/L
afrittoli
force-pushed
the
run_events_controller
branch
from
22d97da
to
1deb126
Compare
vdemeester
approved these changes
Apr 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
wlynch
requested changes
Apr 14, 2023
| namespace: tekton-pipelines | ||
| roleRef: | ||
| kind: Role | ||
| name: tekton-pipelines-leader-election |
There was a problem hiding this comment.
I wonder if there's a way to isolate this set of leader election resources with the main controller 🤔 (i don't know if this is feasible)
There was a problem hiding this comment.
I think the leader's election of the new binary will be independent, even if they share the role, but I will double-check.
This is the first step towards moving the whole cloudevents logic to a dedicated controller. The `Run` controller is already separated from the other controllers, but it's compiled and deployed in the shared binary. In this change we move that controller to a dedicated binary, with its own deployment, service account, roles and bindings. This new binary shares the config maps from the pipeline binary, so that existing configuration options and docs continue to apply with no change. Because of injection, all the informers are setup for this binary, which means that the service account requires read access to the various tekton resources. This is fine however considering that eventually this controller will handle events for all tekton pipeline resources. The publish task is amended to expect the new events image by default as well. Partially-fixes: tektoncd#2944 Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
run_events_controller
branch
from
1deb126
to
4caa0eb
Compare
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is the first step towards moving the whole cloudevents logic to a dedicated controller.
The
Runcontroller is already separated from the other controllers, but it's compiled and deployed in the shared binary. In this change we move that controller to a dedicated binary, with its own deployment, service account, roles and bindings.This new binary shares the config maps from the pipeline binary, so that existing configuration options and docs continue to apply with no change.
Because of injection, all the informers are setup for this binary, which means that the service account requires read access to the various tekton resources. This is fine however considering that eventually this controller will handle events for all tekton pipeline resources.
The publish task is amended to expect the new events image by default as well.
Partially-fixes: #2944
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind misc