Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0089: Refactor setting of "enforce-nonfalsifiability" feature flag #6527

Merged
merged 1 commit into from
Apr 14, 2023
Merged

TEP-0089: Refactor setting of "enforce-nonfalsifiability" feature flag #6527

merged 1 commit into from
Apr 14, 2023

Conversation

jerop
Copy link
Member

@jerop jerop commented Apr 12, 2023 •
edited
Loading

Changes

In this change, we refactor the code for setting enforce-nonfalsifiability feature flag to make it easier to understand, and consistent with the rest of the code. This refactor will make it easier to promote the feature to beta, and beyond.

This change also documents that enable-api-fields has to be set to "alpha" for non-falsifiability to work.

This commit also includes a change to TestNewFeatureFlagsConfigMapErrors to check the exact error, instead of just checking that there was an error. This is useful in validating that both errors that can be triggered while setting the enforce-nonfalsifiability feature flag are tested.

/kind cleanup
/cc @jagathprakash

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 12, 2023
@tekton-robot
Copy link
Collaborator

@jerop: GitHub didn't allow me to request PR reviews from the following users: jagathprakash.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

In this change, we refactor the code for setting "enforce-nonfalsifiability" feature flag to make it easier to understand, and consistent with the rest of the code. It also removes a confusing behavior in non-alpha mode where it would override the user-specified value, set the flag to "none" and then throw an error message. With this change, we just throw an error message directly.

This change also documents that enable-api-fields has to be set to "alpha" for non-falsifiability to work.

/kind cleanup
/cc @jagathprakash

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2023
@jerop jerop mentioned this pull request Apr 12, 2023
Merged
7 tasks
@jerop jerop force-pushed the spire-alpha branch 2 times, most recently from ee38a99 to b49e78e Compare April 12, 2023 22:32
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.9% 0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.9% 0.2

@jagathprakash
Copy link
Member

/lgtm

@tekton-robot
Copy link
Collaborator

@jagathprakash: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chuangw6
Copy link
Member

/assign

@chuangw6
Copy link
Member

/lgtm

Thanks @jerop

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@chuangw6
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@chuangw6
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@jerop
TEP-0089: Refactor setting of "enforce-nonfalsifiability" feature flag
f01ee2e 
In this change, we refactor the code for setting "enforce-nonfalsifiability"
feature flag to make it easier to understand, and consistent with the rest
of the code. This refactor will make it easier to promote the feature to beta,
and beyond.

This change also documents that `enable-api-fields` has to be set to `"alpha"`
for non-falsifiability to work.

This commit also includes a change to `TestNewFeatureFlagsConfigMapErrors` to
check the exact error, instead of just checking that there was an error. This
is useful in validating that both errors that can be triggered while setting
the "enforce-nonfalsifiability" feature flag are tested.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@chuangw6
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.7% 92.6% -0.2

dibyom
dibyom reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@tekton-robot tekton-robot merged commit 11f3b26 into tektoncd:main Apr 14, 2023
@jagathprakash jagathprakash mentioned this pull request Apr 28, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagathprakash jagathprakash jagathprakash left review comments

@chuangw6 chuangw6 chuangw6 left review comments

@dibyom dibyom dibyom left review comments

Assignees

@chuangw6 chuangw6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jerop @tekton-robot @jagathprakash @chuangw6 @dibyom