Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup unused functions in the resources #6473

Merged
merged 1 commit into from
Apr 4, 2023
Merged

chore: cleanup unused functions in the resources #6473

merged 1 commit into from
Apr 4, 2023

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Mar 31, 2023 •
edited
Loading

Changes

These functions are no longer needed after the previous refactoring, so they can be cleaned up.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 31, 2023
@l-qing
Copy link
Contributor Author

l-qing commented Mar 31, 2023

/kind cleanup

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2023
@tekton-robot
Copy link
Collaborator

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 31, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

l-qing
l-qing commented Mar 31, 2023
View reviewed changes
pkg/reconciler/pipelinerun/resources/resultrefresolution.go
@@ -71,29 +71,6 @@ func validateArrayResultsIndex(allResolvedResultRefs ResolvedResultRefs) (Resolv
return allResolvedResultRefs, "", nil
}

// extractResultRefs resolves any ResultReference that are found in param or pipeline result
// Returns nil if none are found
func extractResultRefsForParam(pipelineRunState PipelineRunState, param v1beta1.Param) (ResolvedResultRefs, error) {
Copy link
Contributor Author

@l-qing l-qing Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two functions are currently not being used except for unit testing, so they can be cleaned up.

@JeromeJu
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@JeromeJu
Copy link
Member

Thanks for the cleanup @l-qing , can we have a bit more clarification on the PR title ie. PipelineRun Reconciler Resources? might be helpful to also include some commit message for details.

@l-qing l-qing force-pushed the chore/cleanup-result-ref-resolution branch from 4f97585 to 6b1fc7e Compare March 31, 2023 09:59
@l-qing
Copy link
Contributor Author

l-qing commented Mar 31, 2023

/retest

@l-qing l-qing force-pushed the chore/cleanup-result-ref-resolution branch from 6b1fc7e to f255ec4 Compare March 31, 2023 11:14
@l-qing
Copy link
Contributor Author

l-qing commented Mar 31, 2023

/retest

@l-qing l-qing force-pushed the chore/cleanup-result-ref-resolution branch from f255ec4 to 60de20d Compare March 31, 2023 15:39
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@l-qing l-qing force-pushed the chore/cleanup-result-ref-resolution branch from 60de20d to e93420d Compare April 1, 2023 00:19
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@l-qing
chore: cleanup unused functions in the pipelineRun ceconciler resources
83e7c99 
These functions are no longer needed after the previous refactoring,
so they can be cleaned up.
@l-qing l-qing force-pushed the chore/cleanup-result-ref-resolution branch from e93420d to 83e7c99 Compare April 3, 2023 07:25
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.3% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 89.0% -3.9

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@l-qing
Copy link
Contributor Author

l-qing commented Apr 4, 2023

/auto-cc

@l-qing
Copy link
Contributor Author

l-qing commented Apr 4, 2023

/assign

@l-qing l-qing removed their assignment Apr 4, 2023
@JeromeJu
Copy link
Member

JeromeJu commented Apr 4, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@l-qing
Copy link
Contributor Author

l-qing commented Apr 4, 2023

/lgtm

Thank you for your comment. @JeromeJu

@tekton-robot tekton-robot merged commit aa1f389 into tektoncd:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

@dibyom dibyom Awaiting requested review from dibyom

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l-qing @tekton-robot @JeromeJu @vdemeester