Split up and refactor isCustomTask
#6447
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
flake #4169 /retest |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
jerop
force-pushed
the
iscustomtask
branch
2 times, most recently
from
cc606ca
to
c0cb9ba
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/retest |
In this change, we clean up the `isCustomTask` function: - Remove unused `context.Context`. - Remove the check that either `TaskRef` or `TaskSpec` is specified because we check that way before - see [code]. - Define the check that `TaskRef` is a `CustomTask` as a member function of `TaskRef`; and add tests for the member function. - Define the check that `TaskSpec` is a `CustomTask` as a member function of `TaskSpec`; and add tests for the member function. - Update the docstring for `Kind` and `APIVersion` in `TaskRef`. There are no user-facing changes in this commit. [code]: https://github.com/tektoncd/pipeline/blob/b7d815a9d8528547994f65da097050f472bbb8b2/pkg/apis/pipeline/v1beta1/pipeline_types.go#L216-L227
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Changes
In this change, we clean up the
isCustomTaskfunction:context.Context.TaskReforTaskSpecis specified because we check that way before - see code.TaskRefis aCustomTaskas a member function ofTaskRef; and add tests for the member function.TaskSpecis aCustomTaskas a member function ofTaskSpec; and add tests for the member function.KindandAPIVersioninTaskRef.There are no user-facing changes in this commit.
From this cleanup, there are two issues that have been raised that will be addressed separately:
Kindwith emptyAPIVersioninTaskRefis aTask#6459/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
[ ] Has Docs included if any changes are user facing/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new releaseRelease Notes