-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: added a note on pulling task image from private repo #6426
Conversation
|
Hi @adelmoradian. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jerop |
@adelmoradian please sign the CLA: #6426 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @adelmoradian, and welcome to the Tekton community!
/meow
Please add more details in the commit message, for example:
doc: added a note on pulling task image from private repo
if a task uses an image from a private repo, then `imagePullSecrets`
must be provided at runtime - added note to the tasks docs
Standards: https://github.com/tektoncd/community/blob/main/standards.md#commit-messages
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6502ea8
to
5cb77b9
Compare
prior to this, docs were not clear on how to use a private image for a task - issue tektoncd#3604 if a task uses an image from a private repo, then `imagePullSecrets` must be provided at runtime via `podTemplate` - added note to the tasks docs
5cb77b9
to
f0a3b3f
Compare
@jerop amended the commit message and signed the CLA! |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @adelmoradian!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Added a note on pulling task image from private repo.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes